grpc-js: Optimizing buffer allocation for server server and bidi streams #2658
+54
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For ease of review, I'd really prefer this PR to just contain the functional changes, and to handle the reformatting separately. |
|
Hope it's more readable at now |
murgatroid99
reviewed
Feb 2, 2024
|
I'm concerned about the Linux test failures. I don't know why this change would cause some calls to be cancelled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logical continuation of PR #2652
Reduced allocated memory while making gRPC grame from 2N+5 bytes to N+5 bytes (where N is length of serialized message)
P.S. Sorry for large diff, this file does not meet the prettier conditions in
masterbranch